Skip to content

can borrow mut in proc Issue 10617 #11626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2014
Merged

can borrow mut in proc Issue 10617 #11626

merged 1 commit into from
Jan 28, 2014

Conversation

@nickdesaulniers
Copy link

@nickdesaulniers nickdesaulniers commented Jan 17, 2014

alexcrichton
alexcrichton reviewed Jan 17, 2014
View reviewed changes
src/librustc/middle/kind.rs Outdated
Copy link
Member

@alexcrichton alexcrichton Jan 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this function is a no-op now, perhaps it can be removed?

@alexcrichton
Copy link
Member

alexcrichton commented Jan 17, 2014

Thanks for the fix!

Could you amend the message to include the phrase Closes #10617? Github will auto-close the issue when this gets merged at that point.

nickdesaulniers
nickdesaulniers reviewed Jan 17, 2014
View reviewed changes
src/librustc/middle/kind.rs Outdated
Copy link
Author

@nickdesaulniers nickdesaulniers Jan 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this function is a no-op now, perhaps it can be removed?

Even with this branch? (Testing a build right now)

@huonw
Copy link
Contributor

huonw commented Jan 17, 2014

(@alexcrichton you can actually edit the PR text to include that yourself; it'll have the same effect. :) )

@nickdesaulniers
Copy link
Author

nickdesaulniers commented Jan 17, 2014

review? @alexcrichton

@alexcrichton
Copy link
Member

alexcrichton commented Jan 17, 2014

Looks good to me! I'd want @nikomatsakis or someone more knowledgeable to sign off though, I'm unsure of what repercussions this has on other components.

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 22, 2014

I will check it out soon

@alexcrichton
Copy link
Member

alexcrichton commented Jan 28, 2014

Looks like this has merge conflicts now :(

@nickdesaulniers
Copy link
Author

nickdesaulniers commented Jan 28, 2014

@alexcrichton : fixed. review?

bors added a commit that referenced this pull request Jan 28, 2014
@bors
auto merge of #11626 : nickdesaulniers/rust/issue10617, r=alexcrichton
8c6c229 
#10617
@bors bors closed this Jan 28, 2014
@bors bors merged commit ea9db66 into rust-lang:master Jan 28, 2014
@nickdesaulniers nickdesaulniers deleted the issue10617 branch January 28, 2014 23:17
@nickdesaulniers nickdesaulniers mentioned this pull request Jan 31, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nickdesaulniers @alexcrichton @huonw @nikomatsakis @bors